Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperglass-agent: TLS files requires even if ssl is disabled #85

Closed
bastelfreak opened this issue Sep 22, 2020 · 1 comment
Closed

hyperglass-agent: TLS files requires even if ssl is disabled #85

bastelfreak opened this issue Sep 22, 2020 · 1 comment
Assignees
Labels
possible-bug Something isn't working

Comments

@bastelfreak
Copy link
Contributor

Bug Description

Hi, I assumed that if I disable TLS, no TLS certificate / private key are required. But that's not the case.

Expected behavior

given this config:

---
debug: true
listen_address: 127.0.0.1
mode: bird
secret: NCzYFKOdzSrCEJnV8NWH
ssl:
  enable: false

I assume hyperglass would start without the files, but it fails

Steps to Reproduce

start with the config from above

Local Configurations

Logs

output:

$ hyperglass-agent start
❌ Failed to start web server: 2 validation errors for Ssl
cert
  /opt/hyperglass/hyperglass-agent/hyperglass-agent/agent_cert.pem does not exist. (type=value_error)
key
  /opt/hyperglass/hyperglass-agent/hyperglass-agent/agent_key.pem does not exist. (type=value_error)

Simply creating empty files is a workaround that works:

✅ Starting hyperglass agent web server on http://127.0.0.1:8080 🚀 
 

INFO:     Started server process [8957]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:8080 (Press CTRL+C to quit)

Possible Solution

only enforce the presence of the files if TLS is enabled

Environment

Server

Latest hyperglass-agent from pypi on CentOS 7 / Python 3.6

@thatmattlove
Copy link
Owner

Closing, see #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants