Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Generic Command Modeling #110

Closed
thatmattlove opened this issue Jan 26, 2021 · 7 comments
Closed

Implement Generic Command Modeling #110

thatmattlove opened this issue Jan 26, 2021 · 7 comments
Assignees
Labels
feature New feature or request fixed-in-next-release Issue has already been fixed in the next release

Comments

@thatmattlove
Copy link
Owner

thatmattlove commented Jan 26, 2021

See #95

2021 05 27 Edit

I'm modifying this issue to encompass a discussed and highly-requested ability to implement arbitrary commands that are in no way linked to address-family or VRFs, and only optionally use built-in validation.

@thatmattlove thatmattlove added the feature New feature or request label Jan 26, 2021
@thatmattlove thatmattlove self-assigned this Jan 26, 2021
@brevius
Copy link

brevius commented Mar 5, 2021

+1 for that feature 👍
Would it be possible to allow more commands definitions/customization - in addition to those 5 already implemented (bgp, ping traceroute)?
Something like raw output from defined query.

@thatmattlove
Copy link
Owner Author

Hey @brevius - we were discussing this on Telegram the other day, and I agree that we need to genericize the commands so that we end up with built-in commands that are fully validated (and parsed for consumption in a table, where possible), with the ability to add arbitrary commands as well. I've been thinking about various ways to handle this and I think I have some good ideas. I have a lot going on at work in the next couple of weeks, but I'll try to get it done as quickly as possible.

@warriorsoul15
Copy link

These are cisco nxos commands but these are my top 3..

bgp_summary: "show ip bgp summary"
bgp_peer_received: "show bgp ipv4 unicast neighbor {target} received-routes"
bgp_peer_advertised: "show bgp ipv4 unicast neighbor {target} advertised-routes"

@brevius
Copy link

brevius commented Mar 22, 2021

Something usefull for JunOS:
bgp_peer_discarded: "show route receive-protocol bgp {target} table {vrf}.inet.0 hidden"

@thatmattlove thatmattlove changed the title Add a BGP Summary Command Implement Generic Command Modeling May 28, 2021
@thatmattlove thatmattlove added the accepted Issue is confirmed and will be worked on label May 28, 2021
@thatmattlove thatmattlove added fixed-in-next-release Issue has already been fixed in the next release and removed accepted Issue is confirmed and will be worked on labels Dec 9, 2021
@streamthing
Copy link

What about this issue? Will it be done?

@thatmattlove
Copy link
Owner Author

@streamthing The vast majority of this is done in the v2.0.0 branch. Unfortunately, I've had a number of personal and professional obstacles over the past several months that's prevented me from working on much of anything development-related, hyperglass included. I'm hoping to get back to it very soon, though.

The v2.0.0 branch should be usable-ish, you'd just have to really study the codebase to get it working with custom generic commands, as one of the primary things left to do prior to release is write documentation.

@streamthing
Copy link

@thatmattlove No problem, I'll wait for v2.0.0.
Great work, it's works very well! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request fixed-in-next-release Issue has already been fixed in the next release
Projects
None yet
Development

No branches or pull requests

4 participants