Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.location = '#something' #16

Open
yeungda opened this issue Sep 9, 2010 · 1 comment
Open

window.location = '#something' #16

yeungda opened this issue Sep 9, 2010 · 1 comment

Comments

@yeungda
Copy link

yeungda commented Sep 9, 2010

in browsers, setting window.location to '#something' does not cause a page reload. It does in env-js though. i would like to use env.js with a single page web app and this behaviour is preventing the app from working properly when clicking links like .

i would like to write a patch that allows clicking of links to hashes. would you be interested in accepting such a change? From what I understand so far, it means changes to a.js to include the hash in the href getter, and changes to location.assign to identify when the change is a hash change only. i will include tests.

@eeroan
Copy link

eeroan commented Aug 16, 2011

I came up with exactly same problem. A work around is to set document.location.hash, but it becomes nasty when every third party library needs to be updated because of that.

So please, tell me when you have implemented the patch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants