Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Select() variant that exposes metadata #6517

Open
GiedriusS opened this issue Jul 10, 2023 · 6 comments · May be fixed by #6799
Open

Add Select() variant that exposes metadata #6517

GiedriusS opened this issue Jul 10, 2023 · 6 comments · May be fixed by #6799

Comments

@GiedriusS
Copy link
Member

For operator telemetry in https://github.com/thanos-community/promql-engine we would like to have metadata about the Select() function such as how much data and how fast it was retrieved from each StoreAPI. I suggest adding something like SelectWithMetadata() that returns extra information. This later could be used by promql-engine if query analysis is enabled.

@kanha-gupta
Copy link

Hey @GiedriusS I'll take this up for LFX :)
Any docs or past references to understand the implementation logic better ?

@kanha-gupta
Copy link

Hey @GiedriusS I have seen the past PRs of query observability and how the foundation is laid down for it .
Are there any issues to work on related to this for me to gain experience ? Thank you :)

@hirentimbadiya
Copy link

Greetings @GiedriusS , I'm eager to participate in the upcoming LFX mentorship for Fall 2023. As an open-source contributor and member at Layer5, I possess expertise in JavaScript, React.js, and Next.js. Additionally, I also know fundamentals of Golang and TypeScript, and I have familiarity with Docker and Kubernetes. Furthermore, I have a strong understanding of essential computer science topics such as object-oriented programming, data structures, and more. I look forward to contributing my skills and knowledge to this exciting project.

@PranitPatil03
Copy link

Hello @GiedriusS 👋

I'm Pranit Patil, a student pursuing a Bachelor's degree in Computer Science at Mumbai University. Recently, I completed my internship at hubx.ai, where I worked as a full-stack developer intern. Prior to that, I gained experience as a front-end developer intern at Tech Cryptors.

My skills include JavaScript, ReactJS, Node, Express, MongoDB, and CSS libraries, such as Bootstrap. Through various projects, including full-stack ones, I have honed my expertise in full-stack development

I'm keen on participating in the LFX mentorship program and becoming an active community member. I kindly request your assistance in guiding me through project discussions.

Thank you.

@GiedriusS
Copy link
Member Author

Thanks for everyone's interest! I suggest first of all trying to compile and run Thanos & Prometheus locally. Then, you can try improving the documentation if you see any problems with it. You can also take a look at https://github.com/thanos-io/thanos/issues?page=1&q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22, maybe #4664 looks like a good candidate for starters. 😄

@ishashankmittal
Copy link

Hey! @GiedriusS , I am Shashank Mittal pursuing my undergrad at IIT BHU (Indian Institute of Technology (BHU) Varanasi). I am highly interested in Open Source and Software Development. I would love to contribute to Thanos and participate in this LFX Fall'23!

@bazooka3000 bazooka3000 linked a pull request Nov 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants