Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Gateway: Inconsistent error handling on series limits #6316

Closed
yeya24 opened this issue Apr 25, 2023 · 4 comments
Closed

Store Gateway: Inconsistent error handling on series limits #6316

yeya24 opened this issue Apr 25, 2023 · 4 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Apr 25, 2023

#6171 changed the Series request to return gRPC status code ResourceExhausted when limit is reached.

However, we didn't do the same thing for LabelValues and LabelNames request, but they will also potentially hit the series limit when matchers are specified. Now LabelNames and LabelValues returns Internal and Aborted error respectively.

https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L1577
https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L1765

@douglascamata
Copy link
Contributor

douglascamata commented Apr 28, 2023

@yeya24 nice find! We will try to get some new team members to work on this, if you don't mind. Otherwise I'm happy to use my time to fix it.

@yeya24
Copy link
Contributor Author

yeya24 commented Apr 28, 2023

We probably want to do the same for bytesLimiter also. I will probably go ahead and work on the bytesLimiter one and leave the labels one here.

@douglascamata
Copy link
Contributor

Looks like with #6330 and #6325 merged we can close this, am I right, @yeya24?

@yeya24
Copy link
Contributor Author

yeya24 commented Jun 12, 2023

Yes, thanks for the reminder.

@yeya24 yeya24 closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants