v0.31.0 query parameter query.replica-label doesn't take effect on storegateway

[zhangrj]

Thanos version

After update from 0.30.1 to 0.31.0, query parameter query.replica-label doesn't run as expected.

Config

      containers:
        - name: query
          image: registry.cn-hangzhou.aliyuncs.com/zhangrongjie/thanos:v0.31.0
          imagePullPolicy: "IfNotPresent"
          securityContext:
            allowPrivilegeEscalation: false
            readOnlyRootFilesystem: false
            runAsNonRoot: true
            runAsUser: 1001
          args:
            - query
            - --log.level=info
            - --log.format=logfmt
            - --grpc-address=0.0.0.0:10901
            - --http-address=0.0.0.0:10902
            - --query.replica-label=replica
            - --query.replica-label=prometheus_replica
            - --store=dnssrv+_grpc._tcp.thanos-prod-storegateway-headless.thanos-prod.svc.cluster.local
            - --store=dnssrv+_grpc._tcp.thanos-prod-ruler-headless.thanos-prod.svc.cluster.local
            - --store=dnssrv+_grpc._tcp.thanos-prod-receive-headless.thanos-prod.svc.cluster.local
            - --query.lookback-delta=5m
            - --query.auto-downsampling
            - --query.partial-response

when query receive, the result is:

when query storegateway, the result is:

We can see the prometheus_replica label doesn't be duplicated on storegateway.

Then we delete - --query.replica-label=prometheus_replica, the query result become normal: