-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Document different hashing algorithms in receivers #5681
Comments
i would like too work on this issue |
Go for it @rahul3002 💪 |
I have created introduction for hashing algorithm, but I'm bit confused on which file should i add that information, can u give the link of that particular file or location of that file |
I believe new section in https://thanos.io/tip/components/receive.md/ would be the most appropriate. What do you think? |
will do it once then will decide |
should i upload it here |
@rahul3002 What do you mean? Could you open a PR and we can review it? 🙂 |
if u can share me the exact location of the file where I can update algorithm will be really helpful |
Hi, I would like to work on this issue. Can anyone guide me to a starting point? |
@matej-g I would like to work on it. Can you please assign it to me? |
Is your proposal related to a problem?
We recently introduced new hashing algorithm, and although it feels "semi-experimental" to me at this stage, I think it would be good to document both the existing default algorithm and the new algorithm.
Describe the solution you'd like
As a user, when considering Thanos receiver, I want to be able to tell from the docs:
Additional context
The original proposal for Thanos receiver details some working of the Hashmod algorithm: https://thanos.io/tip/proposals-done/201812-thanos-remote-receive.md/
For Ketama, the recent PR is useful for understanding: #5408
The text was updated successfully, but these errors were encountered: