-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use original Minio upstream for Minio client #5393
Comments
Are you planning to help here with PR? 🤗 otherwise I might have time to fix it. We can get back to upstream with config option mentioned minio/mc#3376 (comment) or we can propose fix to upstream |
I do plan on helping with other Thanos issues, but I believe you have more context to address this one @bwplotka :) |
We can't use it until this or something similar is merged: minio/minio-go#1673 I proposed fix to upsteam, let's see. I updated our fork for now: #5474 |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hey, Any update on that? IMDSv2 is a security requirement, hence, we can not leave those hanging fruits |
I believe this can be closed, as it was resolved as part of #5101 . |
Issue #5130 reports two problems, the incompatibility between the local development Minio version and Apple silicon and the need to go back to using Minio's upstream instead of a fork. We opted to keep that issue focused on the local development and create a new one to return to the upstream because this second part is way more complicated.
The context why Thanos is now using a fork of Minio's client can be found here: #3967
@wiardvanrij also provided this example of problems related to using the fork: #5101
To return using the upstream, we need to figure out how to solve the race condition problem stated in the original task (prior to migrating to the fork) so we can help Minio team and move back to the original repository
The text was updated successfully, but these errors were encountered: