Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original Minio upstream for Minio client #5393

Closed
B0go opened this issue May 29, 2022 · 6 comments · Fixed by minio/minio-go#1673
Closed

Use original Minio upstream for Minio client #5393

B0go opened this issue May 29, 2022 · 6 comments · Fixed by minio/minio-go#1673

Comments

@B0go
Copy link
Contributor

B0go commented May 29, 2022

Issue #5130 reports two problems, the incompatibility between the local development Minio version and Apple silicon and the need to go back to using Minio's upstream instead of a fork. We opted to keep that issue focused on the local development and create a new one to return to the upstream because this second part is way more complicated.

The context why Thanos is now using a fork of Minio's client can be found here: #3967

@wiardvanrij also provided this example of problems related to using the fork: #5101

To return using the upstream, we need to figure out how to solve the race condition problem stated in the original task (prior to migrating to the fork) so we can help Minio team and move back to the original repository

@bwplotka
Copy link
Member

bwplotka commented May 30, 2022

Are you planning to help here with PR? 🤗 otherwise I might have time to fix it. We can get back to upstream with config option mentioned minio/mc#3376 (comment) or we can propose fix to upstream

@B0go
Copy link
Contributor Author

B0go commented May 30, 2022

I do plan on helping with other Thanos issues, but I believe you have more context to address this one @bwplotka :)

@bwplotka
Copy link
Member

bwplotka commented Jul 5, 2022

We can't use it until this or something similar is merged: minio/minio-go#1673 I proposed fix to upsteam, let's see.

I updated our fork for now: #5474

@stale
Copy link

stale bot commented Sep 21, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Sep 21, 2022
@oded-dd
Copy link

oded-dd commented Nov 4, 2022

Hey, Any update on that? IMDSv2 is a security requirement, hence, we can not leave those hanging fruits

@markmsmith
Copy link

I believe this can be closed, as it was resolved as part of #5101 .
We are successfully using IMDSv2 with Thanos in our environment.

@stale stale bot removed the stale label Mar 21, 2023
@matej-g matej-g closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants