-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of VERSION file. #4741
Comments
Related conversation: #4738 (comment) |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
I can make the changes. Just to be sure,
🔥➜ thanos git:(main) git describe --tags $(git rev-list --tags --max-count=1)
v0.25.1
🔥➜ thanos git:(main) git describe --tags --always --dirty
v0.24.0-137-g3026e58f I am thinking about using cc @matej-g |
Maybe I'm missing something here, why do we want to dump it into VERSION file? |
Hi @matej-g, thanks for the reply. Actually, I was not sure How the VERSION file works in From a quick glance to the promu source code, they use the following snippet to fetch the version of the repository. func findVersion() (string, error) {
for _, file := range []string{"VERSION", "version/VERSION"} {
b, err := ioutil.ReadFile(file)
if err != nil {
continue
}
return strings.Trim(string(b), "\n\r "), nil
}
return strings.TrimPrefix(shellOutput("git", "describe", "--tags", "--always", "--dirty"), "v"), nil
} ref1: https://github.com/prometheus/promu/blob/b1a2edae78614c8b0ae9e2faa88d14098e96f6d2/pkg/repository/info.go#L149-L159 As evident from the snippet, it tries to run So I was thinking if we get rid of the VERSION file, we need some way to provide the actual version and do the increment through some automated snippets because the default way is not sufficient. That was my preliminary research, it seems I am definitely missing a lot of things : ) Could you please help me clarifying how we are expecting to get rid of the manual versioning? As clearly, I don't have the full context here. Thank you. |
Thanks for checking this! I think all you said makes sense, so it's a matter of either: A) Sticking to #2028 when doing releases. This will make |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
In order to do so we need to:
promu
to handle this case automatically (take correct tag and if inmain
taketag +1 -dev
cc @simonpasquier
The text was updated successfully, but these errors were encountered: