Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos Block UI do not show all blocks in v0.23.0 #4722

Closed
MioOgbeni opened this issue Oct 1, 2021 · 4 comments
Closed

Thanos Block UI do not show all blocks in v0.23.0 #4722

MioOgbeni opened this issue Oct 1, 2021 · 4 comments
Labels

Comments

@MioOgbeni
Copy link
Contributor

MioOgbeni commented Oct 1, 2021

thanos, version 0.23.0 (branch: HEAD, revision: fe0d695)
build user: circleci@80970a8015b2
build date: 20210927-14:57:42
go version: go1.16.8
platform: linux/amd64

What happened:
Hi. I noticed, that new version of Thanos don't show all block from S3 in Block UI.

How you can see on image below. Left side is version v0.22.0 and right side is v0.23.0 (same blocks, same time-range). Also I noticed that ordering of block series is wierd in new version, but it's just a matter of opinions
https://imgur.com/Url1Ee3

How to reproduce it (as minimally and precisely as possible):
Only change version of image, all setting still same.
I'm running Thanos with this flags

tools
bucket
web
--http-address=0.0.0.0:8080
--log.level=info
--log.format=logfmt
--objstore.config-file=/conf/objstore.yml
--refresh=15m
--timeout=5m

Full logs to relevant components:
I think that log is useless, because it also remained the same, but here it is.

level=info ts=2021-10-01T08:50:33.038571732Z caller=factory.go:49 msg="loading bucket configuration"
level=info ts=2021-10-01T08:50:33.23525002Z caller=intrumentation.go:48 msg="changing probe status" status=ready
level=info ts=2021-10-01T08:50:33.334704042Z caller=intrumentation.go:60 msg="changing probe status" status=healthy
level=info ts=2021-10-01T08:50:33.334778343Z caller=http.go:63 service=http/server component=bucket msg="listening for requests and metrics" address=0.0.0.0:8080
ts=2021-10-01T08:50:33.335664274Z caller=log.go:168 service=http/server component=bucket level=info msg="TLS is disabled." http2=false
level=info ts=2021-10-01T08:50:53.638430742Z caller=fetcher.go:476 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=20.403049851s duration_ms=20403 cached=319 returned=108 partial=0
@yeya24
Copy link
Contributor

yeya24 commented Nov 7, 2021

I am not sure why this happened. Probably it is still syncing block metadatas? Is this issue still happening?

@MioOgbeni
Copy link
Contributor Author

MioOgbeni commented Nov 7, 2021

Hi. Yes it is still happening. These blocks are not displayed during several days continuous running of the pod. I think that it has something to do with new UI feature "#4462 UI: Highlighting blocks overlap in the Block UI.", because missing blocks are basically overlapping with already compacted blocks on higher lvl of compaction and only these blocks are missing from UI. But when I turn on this "highlighting" feature in UI, there is not shown ANY block.

I wanted to look into the code to see if this feature was properly implemented, but I have not found the time for this.

@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants