Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar support https and basic auth access to Prometheus #3975

Closed
liangli1213 opened this issue Mar 25, 2021 · 15 comments · Fixed by #4612
Closed

sidecar support https and basic auth access to Prometheus #3975

liangli1213 opened this issue Mar 25, 2021 · 15 comments · Fixed by #4612

Comments

@liangli1213
Copy link

Since Prometheus version 2.24, we can configure basic authentication and TLS for Prometheus, in my case, the Prometheus provide service directly to the whole internal network, so we enable login credential and TLS (we don't want everyone access Prometheus and username/password transmitted with plain text), and meanwhile we need configure thanos sidecar in same Prometheus (we have multiple Prometheus).

The requirement is:

  1. Provide an option to set up username/password used for Prometheus's login
  2. Provide an option like --insecure_skip_verify to skip verify expired certificate
@yeya24
Copy link
Contributor

yeya24 commented Mar 25, 2021

We definitely need this. Help wanted.

@Namanl2001
Copy link
Contributor

Can I take this up?

@Zophar78
Copy link
Contributor

I'm also really looking forward on such feature! ;)

@binhvcom
Copy link

+1

@yeya24
Copy link
Contributor

yeya24 commented Apr 6, 2021

@Namanl2001 Yes, please go ahead.

@bwplotka
Copy link
Member

Acceptance Criteria:

  • User can configure Auth and TLS option for internal Prometheus client that sidecar uses. Ideally we can reuse other Auth and TLS options we have e.g for Alertmanager

@bwplotka
Copy link
Member

We could use similar configuration to: https://thanos.io/tip/components/rule.md/#configuration

@someshkoli
Copy link
Contributor

someshkoli commented Apr 24, 2021

@Namanl2001 you still working on this ? Since there was no activity I made a draft for this out of curiosity 🤔 LMK 🙌

@Namanl2001
Copy link
Contributor

@someshkoli I was just about to start with this, but if you've already drafted some changes, you can continue, and I'll try to help you with that. Thanks

@someshkoli
Copy link
Contributor

@someshkoli I was just about to start with this, but if you've already drafted some changes, you can continue, and I'll try to help you with that. Thanks

Yeah would definitely need some help. Lets take this to PR

@stale
Copy link

stale bot commented Jun 26, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 26, 2021
@someshkoli
Copy link
Contributor

Still valid 👀 #4104 requires another round of review

@stale stale bot removed the stale label Jun 26, 2021
@stale
Copy link

stale bot commented Aug 25, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale
Copy link

stale bot commented Sep 19, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Sep 19, 2021
@yeya24
Copy link
Contributor

yeya24 commented Sep 20, 2021

Still valid and we have #4612 now.

@yeya24 yeya24 reopened this Sep 20, 2021
@stale stale bot removed the stale label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants