-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the request logging #3923
Comments
Any type of checklist for solving this issue?
I'm bit confused :( |
We could start with making simple Go-tests, no need to look for any testing framework. We can also write up unit tests for different functions out in the logging package
|
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
PRs for request logging #3361 #2849 contains some string manipulation, which might create unnecessary panic as observed in #3921
Would be nice to write tests for making sure panics do not happen.
The text was updated successfully, but these errors were encountered: