-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: signal SIGSEGV #3665
Comments
Thanks for the report. |
I also have occasional SIGSEGV with store-0.17.2. Logs look different, so not sure if it is the same issue. Attaching full log. |
Valid bug. First of all on this version store should never fault just panic: https://github.com/thanos-io/thanos/blob/v0.17.2/cmd/thanos/main.go#L34 Maybe we don't recover from panic? Or somehow this statement does not work? 🤔 Secondly, we need to look on LabelValues, looks like we don't properly lock it as reading from block. |
Well, it only applies to the current goroutine and we spawn a bunch of them when responding to calls so it doesn't work like it is supposed to 😛 |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
SIGSEVG happens when accessing un-mmapped files. |
any update for this issue? |
Is it still an issue on the newest version? |
sorry, |
Just got this on 0.25.1 |
Can you try with 0.28.0 ? |
Thanos, Prometheus and Golang version used:
quay.io/thanos/thanos:v0.17.2
Object Storage Provider:
S3
What happened:
This setup is done in EKS. Thanos Store Gateway crashed with the following error. This happened when i run a query on Thanos Query. I have 2 pods (part of a statefulset) for the Thanos Store Gateway (not sure whether this can cause any issue like this). Also, this crash does not happen with every query (i tried running the same query again after the new pods created). So not exactly sure what causes this crash. Could this be somehow related to the resources of the pod?
What you expected to happen:
Thanos Gateway Store not to be crashed when I run a query 😅
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:
Anything else we need to know:
The text was updated successfully, but these errors were encountered: