receive: Use PathOrContent file for the hashring

[bwplotka]

This:

thanos/cmd/thanos/receive.go

Line 67 in a64884b

hashringsFile := cmd.Flag("receive.hashrings-file", "Path to file that contains the hashring configuration.").

[squat]

Specifically, we should allow the Thanos receive component to also take the hashrings configuration as content passed directly to the flag rather than only as file

[Sylfrena]

so you mean that this flag should either take a file path or the file contents directly as string?

[squat]

yes, that's right :)) it should work just like the objstore flags, which use https://github.com/thanos-io/thanos/blob/master/pkg/extflag/pathorcontent.go#L29:6

[daksh-sagar]

@bwplotka Can I work on this, please?

[kakkoyun]

@daksh-sagar I have actually a PR to fix this #3121. Sorry I've forgotten to update this issue.

[daksh-sagar]

@kakkoyun It's allright 🤓

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[kakkoyun]

#3121 is still open and waiting for review cc @squat