Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: Apply consistency delay in compactor for all blocks including compacted ones. #2283

Closed
bwplotka opened this issue Mar 17, 2020 · 3 comments

Comments

@bwplotka
Copy link
Member

Currently, we treat certain blocks in Compactor especially by not applying consistency delay. (compacted, and blocks from repair). This is based on block source. This will not work well for eventually consistent object storages so we need to solve this as well. This was also mentioned as a side task for https://thanos.io/proposals/201901-read-write-operations-bucket.md/

Potentially we can solve it by saving successful compactor block uploads to persistent file, same as shipper to avoid unnecessary duplicated compactions/downsamplings. And we detect when not to compact for missing bits etc, if those are still in an inconsistent state. We need to prepare that when persistent storage is gone, we need to reconcile if we do double compaction etc.

cc @khyatisoneji

@stale
Copy link

stale bot commented Apr 16, 2020

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2020
@stale stale bot closed this as completed Apr 24, 2020
@bwplotka bwplotka reopened this Apr 25, 2020
@stale stale bot removed the stale label Apr 25, 2020
@stale
Copy link

stale bot commented May 25, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 25, 2020
@stale
Copy link

stale bot commented Jun 1, 2020

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant