Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query UI: announced labelsets column does not distinguish labels from different sets #1601

Closed
devnev opened this issue Oct 3, 2019 · 1 comment · Fixed by #1751
Closed

Comments

@devnev
Copy link
Contributor

devnev commented Oct 3, 2019

Thanos, Prometheus and Golang version used:

From /status:

Version 0.7.0
Revision c6eaf68
Branch HEAD
BuildUser circleci@f199bdee6152
BuildDate 20190902-15:43:19
GoVersion go1.12.5

Object Storage Provider:

N/A

What happened:

In case of a thanos query having a store that is itself another thanos query that is announcing all the labelsets from its own stores, the first thanos query ends up displaying a long list of k=v labels without any way to see the boundaries of the label sets.

What you expected to happen:

announced labelsets column groups the labels in each labelset

How to reproduce it (as minimally and precisely as possible):

  • run two prometheuses with thanos sidecars and different external labels
  • run a thanos query with both the sidecars as stores
  • run another thanos query with the previous query as its store
  • look at the stores UI of the last thanos query

Full logs to relevant components:

N/A

Anything else we need to know:

N/A

Environment:

N/A

@bwplotka
Copy link
Member

bwplotka commented Oct 3, 2019

Yup 👍 Thanks for the report. Help wanted - frontend bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants