expose downsampleRaw
function for testing purpose
#4248
Unanswered
yeya24
asked this question in
Questions & Answers
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Now in Thanos codebase, it is hard to create a downsampled block for testing directly. However, this is very much needed in the E2E tests or other unit tests.
I propose to export
downsample.downsampleRaw
method. The current code is:downsampleRaw
will be renamed toDownsampleRaw
anddata []sample
will be changed todata []tsdbutil.Sample
. This is an interface type and is much better for usability. Any thoughts about it?Beta Was this translation helpful? Give feedback.
All reactions