From b68b4e062396f4d90084ee652825dff234bbf718 Mon Sep 17 00:00:00 2001 From: arthur yang Date: Tue, 24 Mar 2020 09:47:30 +0800 Subject: [PATCH] reloadRules initlialization should fail Signed-off-by: arthur yang --- CHANGELOG.md | 1 + cmd/thanos/rule.go | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c62c7f4a44..eb953b79d8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ Since there are no consistency guarantees provided by some Object Storage provid - [#2090](https://github.com/thanos-io/thanos/issues/2090) *breaking* Downsample command: the `downsample` command has moved as the `thanos bucket` sub-command, and cannot be called via `thanos downsample` any more. - [#2294](https://github.com/thanos-io/thanos/pull/2294) store: optimizations for fetching postings. Queries using `=~".*"` matchers or negation matchers (`!=...` or `!~...`) benefit the most. +- [#2301](https://github.com/thanos-io/thanos/pull/2301) Ruler: initlialization fails with filepath bad pattern error and rule manager update error. ## [v0.11.0](https://github.com/thanos-io/thanos/releases/tag/v0.11.0) - 2020.03.02 diff --git a/cmd/thanos/rule.go b/cmd/thanos/rule.go index cdcf3c3ae1..87afc357d3 100644 --- a/cmd/thanos/rule.go +++ b/cmd/thanos/rule.go @@ -495,6 +495,7 @@ func runRule( // Initialize rules. if err := reloadRules(logger, ruleFiles, ruleMgr, evalInterval, metrics); err != nil { level.Error(logger).Log("msg", "initialize rules failed", "err", err) + return err } for { select {