From 745d1dee75d77fc8527f68cd50033b7bf1a63aa9 Mon Sep 17 00:00:00 2001 From: Marco Pracucci Date: Wed, 8 Jul 2020 16:17:03 +0200 Subject: [PATCH] Addressed review comments Signed-off-by: Marco Pracucci --- docs/components/store.md | 13 ++++++++----- pkg/store/limiter.go | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/docs/components/store.md b/docs/components/store.md index 7bb7700356a..132da27f1c8 100644 --- a/docs/components/store.md +++ b/docs/components/store.md @@ -93,11 +93,14 @@ Flags: memory. --store.grpc.series-sample-limit=0 Maximum amount of samples returned via a single - Series call. 0 means no limit. NOTE: For - efficiency we take 120 as the number of samples - in chunk (it cannot be bigger than that), so - the actual number of samples might be lower, - even though the maximum could be hit. + Series call. The Series call fails if this + limit is exceeded. 0 means no limit. NOTE: For + efficiency the limit is internally implemented + as 'chunks limit' considering each chunk + contains 120 samples (it's the max number of + samples each chunk can contain), so the actual + number of samples might be lower, even though + the maximum could be hit. --store.grpc.series-max-concurrency=20 Maximum number of concurrent Series calls. --objstore.config-file= diff --git a/pkg/store/limiter.go b/pkg/store/limiter.go index eb889a0ea69..1e354721c23 100644 --- a/pkg/store/limiter.go +++ b/pkg/store/limiter.go @@ -28,8 +28,8 @@ type Limiter struct { reserved uint64 // Counter metric which we will increase if limit is exceeded. - failedOnce sync.Once failedCounter prometheus.Counter + failedOnce sync.Once } // NewLimiter returns a new limiter with a specified limit. 0 disables the limit.