From 64ab3284058d83d6585cc8688d6bc3eee5ff5212 Mon Sep 17 00:00:00 2001 From: Arthur Date: Wed, 25 Mar 2020 04:38:10 +0800 Subject: [PATCH] reloadRules initlialization should fail (#2301) Signed-off-by: arthur yang --- CHANGELOG.md | 1 + cmd/thanos/rule.go | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9098f88925..4fa0b16735 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel Since there are no consistency guarantees provided by some Object Storage providers, this PR adds a consistent lock-free way of dealing with Object Storage irrespective of the choice of object storage. In order to achieve this co-ordination, blocks are not deleted directly. Instead, blocks are marked for deletion by uploading `deletion-mark.json` file for the block that was chosen to be deleted. This file contains unix time of when the block was marked for deletion. If you want to keep existing behavior, you should add `--delete-delay=0s` as a flag. - [#2090](https://github.com/thanos-io/thanos/issues/2090) *breaking* Downsample command: the `downsample` command has moved as the `thanos bucket` sub-command, and cannot be called via `thanos downsample` any more. - [#2294](https://github.com/thanos-io/thanos/pull/2294) store: optimizations for fetching postings. Queries using `=~".*"` matchers or negation matchers (`!=...` or `!~...`) benefit the most. +- [#2301](https://github.com/thanos-io/thanos/pull/2301) Ruler: initlialization fails with filepath bad pattern error and rule manager update error. ## [v0.11.0](https://github.com/thanos-io/thanos/releases/tag/v0.11.0) - 2020.03.02 diff --git a/cmd/thanos/rule.go b/cmd/thanos/rule.go index cdcf3c3ae1..87afc357d3 100644 --- a/cmd/thanos/rule.go +++ b/cmd/thanos/rule.go @@ -495,6 +495,7 @@ func runRule( // Initialize rules. if err := reloadRules(logger, ruleFiles, ruleMgr, evalInterval, metrics); err != nil { level.Error(logger).Log("msg", "initialize rules failed", "err", err) + return err } for { select {