Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max samples limit #498

Open
yeya24 opened this issue Dec 2, 2024 · 1 comment
Open

Support max samples limit #498

yeya24 opened this issue Dec 2, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@yeya24
Copy link
Contributor

yeya24 commented Dec 2, 2024

#452 supports tracking peak samples during an execution of the query.

What we are still missing from the old Promql engine is max samples limit enforced by flag query.max-samples, which can be used to protect the query engine from getting OOM killed.

https://github.com/prometheus/prometheus/blob/main/cmd/prometheus/main.go#L512

@yeya24 yeya24 added the help wanted Extra attention is needed label Dec 2, 2024
@harry671003
Copy link
Contributor

Is this useful in the engine? Each step is only keeping a batch of 10 samples per series in memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants