Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No changelog found for html-validate #47

Open
RiZKiT opened this issue May 25, 2020 · 3 comments
Open

No changelog found for html-validate #47

RiZKiT opened this issue May 25, 2020 · 3 comments

Comments

@RiZKiT
Copy link

RiZKiT commented May 25, 2020

Sorry, we haven't found any changelog URL for html-validate module.

Repo: https://gitlab.com/html-validate/html-validate/
Package: https://gitlab.com/html-validate/html-validate/-/blob/master/package.json
Changelog: https://gitlab.com/html-validate/html-validate/-/blob/master/CHANGELOG.md

@RiZKiT
Copy link
Author

RiZKiT commented Mar 2, 2021

Problem still exists with version 3.0.0, package.json looks quite complete, so I expect it should work.

Adding a change log entry would be the last option, but a generic solution would be better.

@th0r
Copy link
Owner

th0r commented Mar 2, 2021

Feel free to create a PR which adds gitlab.com to the known repositories - it should fix the issue.

@th0r
Copy link
Owner

th0r commented Mar 2, 2021

Here is the code that checks for all known changelog filenames:

if (repository && repository.url) {
// If repository is located on one of known hostings, then we will try to request
// some common changelog files from there or return URL for "Releases" page
const {fileUrlBuilder, releasesPageUrl} = getRepositoryInfo(repository.url) || {};
if (fileUrlBuilder) {
const possibleChangelogUrls = _.map(COMMON_CHANGELOG_FILES, fileUrlBuilder);
try {
return await Bluebird.any(
_.map(possibleChangelogUrls, url =>
Bluebird
.try(() => got(url))
.return(url)
)
);
} catch (err) {
if (!(err instanceof Bluebird.AggregateError)) throw err;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants