Skip to content

Commit

Permalink
Remove lists::drop_list_duplicates (NVIDIA#11236)
Browse files Browse the repository at this point in the history
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work.

Closes rapidsai/cudf#11114, rapidsai/cudf#11093, rapidsai/cudf#11053, rapidsai/cudf#11034, and closes rapidsai/cudf#9257.

Depends on:
 * rapidsai/cudf#11228
 * rapidsai/cudf#11149
 * rapidsai/cudf#11234
 * rapidsai/cudf#11233

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Robert Maynard (https://github.com/robertmaynard)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai/cudf#11236
  • Loading branch information
ttnghia authored Jul 22, 2022
1 parent 719f4c8 commit a541ffb
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 1,741 deletions.
2 changes: 0 additions & 2 deletions conda/recipes/libcudf/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,11 @@ outputs:
- test -f $PREFIX/include/cudf/lists/detail/concatenate.hpp
- test -f $PREFIX/include/cudf/lists/detail/contains.hpp
- test -f $PREFIX/include/cudf/lists/detail/copying.hpp
- test -f $PREFIX/include/cudf/lists/detail/drop_list_duplicates.hpp
- test -f $PREFIX/include/cudf/lists/detail/extract.hpp
- test -f $PREFIX/include/cudf/lists/detail/interleave_columns.hpp
- test -f $PREFIX/include/cudf/lists/detail/scatter_helper.cuh
- test -f $PREFIX/include/cudf/lists/detail/sorting.hpp
- test -f $PREFIX/include/cudf/lists/detail/stream_compaction.hpp
- test -f $PREFIX/include/cudf/lists/drop_list_duplicates.hpp
- test -f $PREFIX/include/cudf/lists/explode.hpp
- test -f $PREFIX/include/cudf/lists/extract.hpp
- test -f $PREFIX/include/cudf/lists/filling.hpp
Expand Down
1 change: 0 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@ add_library(
src/lists/copying/segmented_gather.cu
src/lists/copying/scatter_helper.cu
src/lists/count_elements.cu
src/lists/drop_list_duplicates.cu
src/lists/explode.cu
src/lists/extract.cu
src/lists/interleave_columns.cu
Expand Down
59 changes: 0 additions & 59 deletions cpp/include/cudf/lists/detail/drop_list_duplicates.hpp

This file was deleted.

119 changes: 0 additions & 119 deletions cpp/include/cudf/lists/drop_list_duplicates.hpp

This file was deleted.

Loading

0 comments on commit a541ffb

Please sign in to comment.