Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting config ignored #72

Open
djamadeus opened this issue May 15, 2023 · 3 comments
Open

Quoting config ignored #72

djamadeus opened this issue May 15, 2023 · 3 comments
Assignees

Comments

@djamadeus
Copy link

The quoting options in source-configuration as well as overwriting values in table-config are being ignored.

sources:
  - name: TEST
    quoting:
      database: true
      schema: true
      identifier: true
    schema: TEST
    tables:
      - name: order
        identifier: order
        quoting:
          identifier: true

The following query gets generated:

Select "id" as original_order_id from TEST.order

@tglunde tglunde self-assigned this May 16, 2023
@matchaEis
Copy link

hello everybody :) we also just stumbled across the same problem with our "sources". Is there any prospect of a solution here?

@djamadeus
Copy link
Author

I found at least a workaround:
you can manually include quotes for sources in yaml like this:

    tables:
      - name: '"a_SALE_ORDER"'

@matchaEis
Copy link

thanks for the hint! :) We got it working like this

tables:
- name: WBS_SAP_ZUO
identifier: '"tbl_WBS_SAP_ZUO"'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants