Skip to content

Commit

Permalink
self-contained:false, include DLL in ZIP
Browse files Browse the repository at this point in the history
the downside of self-contained:true is that
we have to package up the entire publish/
folder

for this app, I think it's reasonable to assume
that they already have .NET Core installed
  • Loading branch information
tgharold authored Apr 2, 2020
1 parent 98a6f52 commit b0cdbae
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/create-release-asset-on-git-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
working-directory: ./src/${{ env.PROJECT }}
run: >
dotnet publish
--self-contained true
--self-contained false
-r linux-x64
--configuration ${{ env.CONFIG }}
/p:Version="${{ env.RELEASE_VERSION }}" /p:InformationalVersion="${{ env.RELEASE_VERSION }}"
Expand All @@ -69,13 +69,14 @@ jobs:
zip --junk-paths ./${{ env.PROJECT }}-${{ env.RELEASE_TAG }}-linux-x64.zip
./LICENSE ./README.md
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/linux-x64/publish/${{ env.PROJECT }}
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/linux-x64/publish/${{ env.PROJECT }}.dll
# ----- osx-x64
- name: dotnet publish osx-x64
working-directory: ./src/${{ env.PROJECT }}
run: >
dotnet publish
--self-contained true
--self-contained false
-r osx-x64
--configuration ${{ env.CONFIG }}
/p:Version="${{ env.RELEASE_VERSION }}" /p:InformationalVersion="${{ env.RELEASE_VERSION }}"
Expand All @@ -87,13 +88,14 @@ jobs:
zip --junk-paths ./${{ env.PROJECT }}-${{ env.RELEASE_TAG }}-osx-x64.zip
./LICENSE ./README.md
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/osx-x64/publish/${{ env.PROJECT }}
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/osx-x64/publish/${{ env.PROJECT }}.dll
# ----- win-x64
- name: dotnet publish win-x64
working-directory: ./src/${{ env.PROJECT }}
run: >
dotnet publish
--self-contained true
--self-contained false
-r win-x64
--configuration ${{ env.CONFIG }}
/p:Version="${{ env.RELEASE_VERSION }}" /p:InformationalVersion="${{ env.RELEASE_VERSION }}"
Expand All @@ -105,6 +107,7 @@ jobs:
zip --junk-paths ./${{ env.PROJECT }}-${{ env.RELEASE_TAG }}-win-x64.zip
./LICENSE ./README.md
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/win-x64/publish/${{ env.PROJECT }}.exe
./src/${{ env.PROJECT }}/bin/${{ env.CONFIG }}/${{ env.TARGET }}/win-x64/publish/${{ env.PROJECT }}.dll
# ------------------------

Expand Down

0 comments on commit b0cdbae

Please sign in to comment.