Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Het count in while loop is missing CA #19

Closed
bryce-turner opened this issue Dec 7, 2023 · 3 comments
Closed

Het count in while loop is missing CA #19

bryce-turner opened this issue Dec 7, 2023 · 3 comments

Comments

@bryce-turner
Copy link
Member

There is a typo here that is likely causing us to not count CA hets. I haven't performed any testing to confirm how problematic this typo is.

snpSniffer/src/Het.java

Line 75 in b59c549

else if (array[this.i][this.j].equals("CT") || array[this.i][this.j].equals("CT") || array[this.i][this.j].equals("CG")) {

@sfacista
Copy link
Contributor

sfacista commented Mar 4, 2024

@bryce-turner I'll update this and re-release the built JAR so you can test .

sfacista added a commit to sfacista/snpSniffer that referenced this issue Mar 4, 2024
@sfacista
Update Het.java
1e4a534 
Updated to resolve issue tgen#19
@sfacista sfacista mentioned this issue Mar 4, 2024
Merged
@sfacista
Copy link
Contributor

sfacista commented Mar 4, 2024

@bryce-turner please see pull request:
#20

@PedalheadPHX
Copy link
Member

Resolved in v7.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PedalheadPHX @sfacista @bryce-turner