Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set dark mode #47

Open
videodj opened this issue Mar 24, 2023 · 6 comments
Open

Can't set dark mode #47

videodj opened this issue Mar 24, 2023 · 6 comments

Comments

@videodj
Copy link

videodj commented Mar 24, 2023

I followed the instructions and have everything running, however when I select dark mode nothing happens am I missing something?

@pedropinn
Copy link

Below where you set the theme (dropdown list) there are 3 checkboxes, automatic, light and dark. You should select dark.

@LegendaryFire
Copy link
Contributor

@videodj @pedropinn I've also had this issue when setting an automation on startup to set the default theme. Although I select dark, it still loads the light theme instead. I'll take a look in the source code sometime in the next few weeks and see if I can find out what's going on with it. Still waiting on my PR for the color fixes to be merged too.

@qJake
Copy link

qJake commented Jul 2, 2023

I found this thread because I can't get the light/dark to work either - it is supposed to be automatic on mobile, but it's defaulting to light.

Honestly, it would be much easier if there was just a "waves-light" and "waves-dark" theme in the dropdown separately so that we can just pick one. (I'm using this as a dashboard theme only, not a system-wide theme, so I don't even have the Light/Dark/Automatic toggle.)

@tgcowell
Copy link
Owner

tgcowell commented Jul 2, 2023

Hi All,

Any chance you could give me any additional info? I have cannot replicate the issue, it changes without any concerns.

Not sure how to even start troubleshooting

@qJake
Copy link

qJake commented Jul 3, 2023

So, I think this is less of a "bug" and more of a request to add additional functionality or otherwise enhance the theme.

Currently, if you set the theme system-wide, you do get the Light/Dark/Auto toggle. That works fine.

But if you want to only use waves on a single dashboard, or a single tab, you can't do that - it defaults to light only. You can't use the dark theme, as far as I can tell (unless I'm missing something obvious?).

image

My request is to have separate waves-light and waves-dark themes so I can pick one specifically. I'm not sure if that's the same thing that @videodj is reporting, if not, I will submit a separate issue!

@freeman59
Copy link

Hello there, I have a different problem. If I put the wave dark in my profile, it works but clear not. I mean it works but I don't have the background for this setting. I tried also to upload a background image when using Wave in a dashboard but it doens't show up either. I've switched to defaut theme on my profile then back to dashboard and put the wave theme, same problem. If I put a specific image on background with a defaut theme, it works so Idk why it's not working when selecting the wave theme

do you have an idea ?

regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants