Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4: Implicitly marking parameter as nullable is deprecated #227

Closed
bloatware opened this issue Aug 29, 2024 · 2 comments
Closed

PHP 8.4: Implicitly marking parameter as nullable is deprecated #227

bloatware opened this issue Aug 29, 2024 · 2 comments
Assignees
Milestone

Comments

@bloatware
Copy link
Collaborator

PHP 8.4 is not released yet, but just in case:

public function __construct(array $data = null)

public function __construct($name, array $attributes = null, $selfclosing = true)

Possibly elsewhere

@gocom
Copy link
Member

gocom commented Aug 29, 2024

Thanks for raising this issue, @bloatware 🙂

Resolving this will require dropping PHP 5 support, or either removing types from arguments. Will likely just drop PHP 5 support, and release it as next major release version.

@gocom gocom self-assigned this Aug 29, 2024
@gocom gocom modified the milestones: 5.0.0, 4.1.2 Aug 29, 2024
@gocom gocom closed this as completed in 70137f3 Aug 29, 2024
@gocom
Copy link
Member

gocom commented Aug 29, 2024

v4.1.2 is now available, and is compatible with PHP 8.4. The PHP 8.4 issues were resolved in backwards compatible fashion, so there is no changes to minimum platform requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants