Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't parse classes with : or ! #224

Closed
zachahn opened this issue Dec 31, 2023 · 1 comment
Closed

Can't parse classes with : or ! #224

zachahn opened this issue Dec 31, 2023 · 1 comment
Assignees
Milestone

Comments

@zachahn
Copy link

zachahn commented Dec 31, 2023

Happy new year!

I'm using the "try Textile" form, so the issue template doesn't quite apply. Apologies in advance if I've miscategorized this! I'm assuming that the form is using this PHP version.

I was originally thinking about raising this issue in the spec repo, but after looking around a bit, this repo seemed to be the canonical Textile implementation.

Problematic Textile markup

p(md:mt-3). hello

p(!mt-3). there

Expected output

<p class="md:mt-3">hello</p>

<p class="!mt-3">there</p>

Actual output

<p>hello</p>

<p>there</p>

Additional information

I'm hoping to use Textile with Tailwind CSS. The two main incompatibilities I see are the characters : and !.

Looking a little deeper, I do see some other characters which are valid Tailwind classes but invalid Textile classes, but I only see them in the context around workarounds. I only use Tailwind in my hobby projects, so I'm far from an authority, but this makes me think that it's not as important to support them—but I'll list what I've found for completeness: ', (, ), &, /, \, and #.

@gocom gocom self-assigned this Jan 2, 2024
@gocom gocom modified the milestones: 4.0.1, 4.1.0 Jan 2, 2024
@gocom gocom closed this as completed in 29e5a13 Jan 2, 2024
@zachahn
Copy link
Author

zachahn commented Jan 3, 2024

Thank you @gocom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants