Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links wrapped in HTML tags generate broken markup with the new link parser #128

Closed
gocom opened this issue Nov 5, 2013 · 1 comment
Closed

Comments

@gocom
Copy link
Member

gocom commented Nov 5, 2013

There is some inconsistencies and possible regression with link parsing. Before the new link parser this:

<span>"link":http://example.com</span>

Generated:

<p><span>“link”:http://example.com</span></p>

Now, it generates a link, but also broken HTML:

<p><span><a href="http://example.com&lt;/span%3E">link</a></p>

The link eats the closing tag. The new parser doesn't detect link end if there is no punctuation mark, end of document or space at the end. It holds true for instance when mixing Textile spans and HTML around the link. This:

??"link":http://example.com??

<span>??example??</span>

Generates:

<p><cite><a href="http://example.com">link</a></cite></p>

<p><span><cite>example</cite></span></p>

While this:

<span>??"link":http://example.com??</span>

Generates:

<p><span>??<a href="http://example.com??&lt;/span&gt;">link</a></p>

Generating both broken HTML, improperly encoded URL and leaving raw Textile to the document.

@gocom
Copy link
Member Author

gocom commented Nov 5, 2013

Closed by d79ef7c

@gocom gocom closed this as completed Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant