[2.5.1] img markup: arg separator broken ..

[jdlx]

Hi,

dunno if this is some local quirk or a real bug.. however this img markup:

!http://rexdev.de/index.php?rex_img_type=github_readme&rex_img_file=lnk_jdlx_agk_patches_structure_mediapool.png!

results in:

<p><img src="http://rexdev.de/index.php?rex_img_type=github_readme&amp;amp;rex_img_file=lnk_jdlx_agk_patches_structure_mediapool.png" alt="" /></p>

note the &

Can others verify? (happens in 2.4.1 as well for me.. and arg_separator.output seems not to be an issue..)

cheers,
Jan

[netcarver]

Yes, I'm seeing this too with v2.5.1.

[netcarver]

Jan, try commenting out this line in fImage()...

$url = htmlspecialchars($url, ENT_QUOTES, 'UTF-8');

[jdlx]

Getting & now..

[jdlx]

I wonder if Textile should do this hardcoded replacement in urls.. i think it should do according to arg_separator.output settings.

[jdlx]

Plus: the above htmlspecialchars(... code: shouldn't that rather be urlencode()?

[netcarver]

Textile doesn't (directly) use the arg_separator.output setting. I hope to get some more time to investigate and fix this this week.

[jdlx]

I'm a bit clueless where the &->$amp; replacement takes place.. a quick debugging with firephp seems to point to retrieveURLs() though i don't see how/why the preg_replace_callback there should do that.

[jdlx]

Ah.. i missed it in the callback.. so it's happening here: https://github.com/netcarver/textile/blob/6caa17c9aae18a658b2b4006c9a52cfc85637d8a/classTextile.php#L2453

(Edited by netcarver to fix link to specific commit)