Do not attempt to allocate >= 4 GiB on 32-bit systems #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tevador
commented
Jul 3, 2019
tevador
commented
- Cache size limited to 2 GiB
+ Cache size limited to 2 GiB
hyc
reviewed
Jul 3, 2019
| @@ -102,6 +103,12 @@ extern "C" { | |||
| } | |||
|
|
|||
| randomx_dataset *randomx_alloc_dataset(randomx_flags flags) { | |||
|
|
|||
| //fail on 32-bit systems if DatasetSize is >= 4 GiB | |||
There was a problem hiding this comment.
Shouldn't the failure threshold be much smaller? At 4GiB there is no room in the address space for any other code or data.
There was a problem hiding this comment.
If the computer doesn't have enough virtual memory (which is likely) then the allocation will fail naturally.
This condition is in place to prevent an overflow which could make the allocation to falsely succeed. For example if DatasetSize is 4.5 GiB, it will overflow to 0.5 GiB on 32-bit systems and only 0.5 GiB will be allocated, leading to runtime crashes.
hyc
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.