replace hardcoded literal with its appropriate symbol #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your first commit looks correct. The second commit has nothing to do with the topic and should be in a separate PR. |
|
oops, yeah didn't mean to include that one. fixing... |
|
second commit reverted |
|
you should have just used git rebase to delete the unintended commit and then force-pushed your branch. |
cryptonote-social
force-pushed
the
master
branch
from
5645858
to
a7733de
Compare
|
done |
hyc
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe his hardcoded "8" should actually be RegistersCount, just in case anyone tries to create a variant with more/fewer registers.