Selenium 4 and Appium 2 Upgrade #360

vikramvr20 · 2023-04-27T07:25:01Z

Description

Upgraded selenium version to 4.8.2
Upgraded appium version to 8.3.0

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Changes would cause existing functionality to not work as expected
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

1. Updating to Appium Java client 8

https://www.selenium.dev/documentation/webdriver/getting_started/upgrade_to_selenium_4/#merging-capabilities-is-no-longer-changing-the-calling-object

Tested and made changes as per Appium 2 and appium java client 8.3.0

CLAassistant · 2023-04-27T07:25:09Z

All committers have signed the CLA.

...rc/com/testsigma/automator/actions/mobile/android/generic/ChangeScreenOrientationAction.java

Addressing review comments

…into selenium4

server/src/main/java/com/testsigma/service/TestsigmaLabDriverSettingsService.java

PratheepV · 2023-05-03T10:14:59Z

agent/src/main/java/com/testsigma/agent/mobile/MobileAutomationServer.java

      this.mobileAutomationServerExecutablePath = new File(PathUtil.getInstance().getMobileAutomationServerPath(), "appium");
      if (SystemUtils.IS_OS_WINDOWS) {
        this.mobileAutomationServerExecutablePath = new File(PathUtil.getInstance().getMobileAutomationServerPath(), "appium.exe");
      }
      this.serverIpAddress = serverIP();
      this.logFilePath = new File(PathUtil.getInstance().getLogsPath() + File.separator + "appium.log");
      Integer serverPort = NetworkUtil.getFreePort();
-      this.serverURL = String.format("http://%s:%d/wd/hub", serverIpAddress, serverPort);


@vikramvr20 we need to have Appium server also need to upgraded. jfyi

@vikramvr20 Please confirm and do necessary changes..

@PratheepV - Yes that's already been done and discussed the approach with Rajesh and Vikram.

Upgraded Agent version

Changed uiautomator2 apk file version

Upgrading appium client version to 8.4.0

rajesh-testsigma · 2023-05-09T13:16:23Z

automator/pom.xml

@@ -298,6 +310,12 @@
      <artifactId>log4j-api</artifactId>
      <version>2.17.1</version>
    </dependency>
+    <dependency>
+      <groupId>org.springframework</groupId>


Why do we need this in automator?

Getting the below error without adding the dependency. Hence added the same.

automator/src/com/testsigma/automator/actions/AddonAction.java

automator/src/com/testsigma/automator/actions/ElementAction.java

rajesh-testsigma · 2023-05-09T13:23:27Z

automator/src/com/testsigma/automator/actions/mobile/MobileDriverAction.java

@@ -9,14 +9,20 @@

 package com.testsigma.automator.actions.mobile;

+


Format this file, remove unwanted empty lines

rajesh-testsigma · 2023-05-09T13:45:51Z

automator/src/com/testsigma/automator/actions/mobile/SwipeAction.java

@@ -29,7 +38,12 @@ public class SwipeAction extends MobileDriverAction {
  public void execute() throws Exception {
    PointOption startingPoint = PointOption.point(tapPoints[0].getX(), tapPoints[0].getY());
    PointOption endingPoint = PointOption.point(tapPoints[1].getX(), tapPoints[1].getY());
-    new TouchAction<>(getDriver()).press(startingPoint)
-      .waitAction(WaitOptions.waitOptions(Duration.ofSeconds(1))).moveTo(endingPoint).release().perform();
+    PointerInput FINGER = new PointerInput(TOUCH, "finger");


Rename the variable FINGER, use camel case

rajesh-testsigma · 2023-05-09T13:54:38Z

automator/src/com/testsigma/automator/actions/mobile/ios/generic/HideKeyboardAction.java

+      getDriver().switchTo().activeElement().sendKeys(Keys.RETURN);
+      log.error("Hide keyboard by switching to active element and clicking enter");
+    } catch (Exception e) {
+      log.error("Could not hide keyboard by switching to active element and clicking enter");


log the exception as well. log.error("Could not hide keyboard.....",e);

rajesh-testsigma · 2023-05-09T13:56:11Z

automator/src/com/testsigma/automator/actions/mobile/ios/generic/HideKeyboardAction.java

+              try {
+                getDriver().findElement(By.xpath("//*[contains(@name, '" + button + "')]")).click();
+              } catch (Exception e) {
+                log.error(e, e);


never use log.error(e,e), u cannot search for exception globallky. add some mesningfiul message
log.error("message",e); also do not use e.getMessage() in place of message

PratheepV · 2023-05-19T08:03:02Z

server/src/main/java/com/testsigma/service/TestsigmaLabDriverSettingsService.java

@@ -145,4 +143,16 @@ public void setWebCapabilities(TestDevice testDevice,
  public Integrations getLabDetails() throws IntegrationNotFoundException {
    return this.integrationsService.findByApplication(Integration.TestsigmaLab);
  }
+
+  public String getExecutionName(TestPlanResult testPlanDetails) {


@vikramvr20 can we exclude runId so that we don't need to pollute methods with TestPlanResult as an argument and as its for debugging only I feel its not worth

PratheepV · 2023-05-19T08:03:33Z

server/src/main/resources/application.properties

@@ -1,6 +1,6 @@
 server.port=${TESTSIGMA_SERVER_PORT:9090}
 server.url=${TESTSIGMA_SERVER_URL:https://local.testsigmaos.com}
-server.version=v2.9.1
+server.version=v2.9.2


@vikramvr20 can we have the version as 3.0.0 because its major release

Addressing review comments

Changing testsigma java sdk version

upgrading agent version

Pointing proxy to staging instance for testing

Added logic to extract uiautomator2 and xcuitest driver from the respective zip files.

Fixed null pointer exception related to wda process.

Addressed review comments.

correcting indentation

…into selenium4

Changed testsigma platform url to default.

…into selenium4

gayathri-testsigma and others added 13 commits March 7, 2023 14:18

(feat): Selenium 4 upgrade part 1

32a3ff3

TRD-217_upgrade

03a43b6

1. Updating to Appium Java client 8

Merge remote-tracking branch 'origin/TRD-217_upgrade' into selenium4

b03c05d

(feat): merge conflicts

db730c9

Made changes wrt to appium java client 8

9c3ad06

(feat): dependency updates

defc58f

fix merging capabailities

a234597

https://www.selenium.dev/documentation/webdriver/getting_started/upgrade_to_selenium_4/#merging-capabilities-is-no-longer-changing-the-calling-object

(feat): selenium fixes

7ad4771

feat: selenium 4 latest dependency

2ab5966

selenium 4 minor changes

61195a3

Merge branch 'dev' into selenium4

a07855f

TRD-217

6482009

Tested and made changes as per Appium 2 and appium java client 8.3.0

feat(Se4): fixes

ee23069

vikramvr20 requested review from rajesh-testsigma, vikram-chaitanya and PratheepV April 27, 2023 07:26

vikram-chaitanya reviewed Apr 28, 2023

View reviewed changes

...rc/com/testsigma/automator/actions/mobile/android/generic/ChangeScreenOrientationAction.java Outdated Show resolved Hide resolved

vikram-chaitanya approved these changes Apr 28, 2023

View reviewed changes

vikramvr20 and others added 3 commits May 2, 2023 17:14

TRD-217

99552e1

Addressing review comments

fix(se4): remove hardcoded desired capability

19eab55

Merge branch 'selenium4' of https://github.com/testsigmahq/testsigma …

9f573a4

…into selenium4

PratheepV requested changes May 3, 2023

View reviewed changes

server/src/main/java/com/testsigma/service/TestsigmaLabDriverSettingsService.java Outdated Show resolved Hide resolved

fix(se4): address review comment

c06fd97

gayathri-testsigma requested a review from PratheepV May 4, 2023 13:30

PratheepV approved these changes May 8, 2023

View reviewed changes

vikramvr20 added 3 commits May 8, 2023 17:59

TRD-217

09f1b45

Upgraded Agent version

TRD-217

083eb0a

Changed uiautomator2 apk file version

TRD-217

bec7769

Upgrading appium client version to 8.4.0

rajesh-testsigma reviewed May 9, 2023

View reviewed changes

vikramvr20 requested a review from PratheepV May 18, 2023 15:42

PratheepV requested changes May 19, 2023

View reviewed changes

vikramvr20 and others added 23 commits May 19, 2023 14:47

TRD-217

4e52ce4

Addressing review comments

TRD-217

6223dc4

Changing testsigma java sdk version

TRD-217

8be562e

upgrading agent version

TRD-217

7f83678

upgrading agent version

TRD-217

ca66b72

Pointing proxy to staging instance for testing

(feat): private grid + se4 features

e3883f6

(feat): grid fixes

334a08a

fixes for grid

42b88e0

(feat): Element level screenshot

ab37e02

(feat): Driver Manager

8c0dd8d

TRD-217

62dcbdd

Added logic to extract uiautomator2 and xcuitest driver from the respective zip files.

bug: name for edge browser is changed in grid4

47a9d84

TRD-217

9779297

Fixed null pointer exception related to wda process.

TRD-217

6146b41

Addressed review comments.

TRD-217

374a7a1

correcting indentation

chore: remove unused imports

b1b94f6

Merge branch 'selenium4' of https://github.com/testsigmahq/testsigma …

349fd98

…into selenium4

Merge branch 'dev' into selenium4

e8967b4

chore: remove unused imports

d8ba1e4

chore: code style fixes

0732973

TRD-217

634f468

Changed testsigma platform url to default.

Merge branch 'selenium4' of https://github.com/testsigmahq/testsigma …

bbe930a

…into selenium4

bug: name key in desiredcap for local run

50889d9

PratheepV approved these changes Jun 14, 2023

View reviewed changes

vikram-chaitanya approved these changes Jun 20, 2023

View reviewed changes

rajesh-testsigma approved these changes Jun 20, 2023

View reviewed changes

PratheepV merged commit 842c2b8 into dev Jun 24, 2023

PratheepV deleted the selenium4 branch June 24, 2023 06:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium 4 and Appium 2 Upgrade #360

Selenium 4 and Appium 2 Upgrade #360

vikramvr20 commented Apr 27, 2023 •

edited

Loading

CLAassistant commented Apr 27, 2023 •

edited

Loading

PratheepV May 3, 2023

PratheepV May 8, 2023

vikramvr20 May 8, 2023

rajesh-testsigma May 9, 2023

vikramvr20 May 16, 2023

rajesh-testsigma May 9, 2023

vikramvr20 May 16, 2023

rajesh-testsigma May 9, 2023

vikramvr20 May 16, 2023

rajesh-testsigma May 9, 2023

vikramvr20 May 18, 2023

rajesh-testsigma May 9, 2023

vikramvr20 May 16, 2023

PratheepV May 19, 2023

vikramvr20 Jun 20, 2023

PratheepV May 19, 2023

vikramvr20 Jun 20, 2023

		@@ -9,14 +9,20 @@

		package com.testsigma.automator.actions.mobile;

Selenium 4 and Appium 2 Upgrade #360

Selenium 4 and Appium 2 Upgrade #360

Conversation

vikramvr20 commented Apr 27, 2023 • edited Loading

Description

Checklist:

CLAassistant commented Apr 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikramvr20 commented Apr 27, 2023 •

edited

Loading

CLAassistant commented Apr 27, 2023 •

edited

Loading