-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fireEvent): Make sure react dispatches focus/blur events #758
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40fbff1:
|
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 101 109 +8
Branches 16 16
=========================================
+ Hits 101 109 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable 👍 thanks!
🎉 This PR is included in version 10.4.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Fix failing tests for
react@experimental
Why:
react@experimental
: In casenext
is not released alongsideexperimental
(such is the case right now). We don't support any experimental API right now but setting up infra before actual feature work makes feature work more approachable.How:
react@experimental
(in addition tonext
andlatest
)Switch from
REACT_NEXT
environment flag toREACT_DIST
enum which can hold a valid npm dist tag for react.focusin
alongsidefocus
andfocusout
alongsideblur
which is similar to how we handlemouseEnter
/mouseLeave
.Ideally we'd get everybody on board to using
.focus()
andblur()
instead but that would only work with[email protected]
or a browser which is less than ideal.Checklist:
[ ] Documentation added to thedocs site
[ ] Typescript definitions updated