Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub actions instead of Travis CI #530

Closed
MichaelDeBoey opened this issue Nov 14, 2019 · 7 comments
Closed

Use GitHub actions instead of Travis CI #530

MichaelDeBoey opened this issue Nov 14, 2019 · 7 comments

Comments

@MichaelDeBoey
Copy link
Member

GitHub made their Actions (CI) public, so I think it would be nice to use it in the repos instead of Travis CI.

https://github.com/features/actions

@eps1lon
Copy link
Member

eps1lon commented Nov 14, 2019

What issues would this solve for us?

@MichaelDeBoey
Copy link
Member Author

It's just a more integrated way of doing CI, where you can just stay on GitHub to watch what happened instead of needing to go to Travis.

@eps1lon
Copy link
Member

eps1lon commented Nov 14, 2019

I think I'd rather click one more time occasionally than migrate CI. That's usually not a trivial task. So feel free to work on this. But unless someone can demonstrate some issues with the current CI I don't see the necessity to put time into this.

It's a bit confusing to me that all the argument you can make is about having to navigate. I've seen several opened issues from you on various repositories I work on so I would've expected more arguments if you're so enthusiastic about github actions or codesandbox ci or github sponsors.

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Nov 14, 2019

Doh! 😓
I forgot to update my previous comment with the following:

Numbers from the GitHub Universe 2019 keynote also see a massive time improvement (Pinterest had their pipeline down from 80 to 10 mins) when using GitHub Actions instead.

@eps1lon
Copy link
Member

eps1lon commented Nov 14, 2019

I'm sorry this is the kind of situation I shouldn't argue but I will not platform these statements unquestioned:

Numbers from the GitHub Universe 2019 keynote also see a massive time improvement (Pinterest had their pipeline down from 80 to 10 mins) when using GitHub Actions instead.

Pinterest moved from a single pipeline in BuildKite to 8 pipelines on github actions (TextureGroup/Texture#1623) which incidentally accounts exactly for 7/8 time reduction. This is advertisement for parallel pipelines not github actions.

@alexkrolick
Copy link
Collaborator

I'd prefer not to go all-in on GitHub infrastructure at this time.

@kentcdodds
Copy link
Member

I agree. It's too early. Let's hold off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants