Merge extended matchers with the global namespace #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 89 89
Branches 23 23
=====================================
Hits 89 89Continue to review full report at Codecov.
|
|
Alright cool! Thanks for adding this... @allcontributors can you please add @marnusw for code? |
|
I've put up a pull request to add @marnusw! 🎉 |
bcarroll22
approved these changes
Jul 15, 2019
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes TypeScript failing to find extended expect methods
Closes #7
How:
By default a
d.tsfile augments the global namespace. As soon as animportorexportis used in thed.tsfile it changes to a module definition. This makes it necessary to usedeclare global {}to add to the global namespace explicitly. Injest-dom/extend-expect.d.tswhich the current implementation is based on there are no imports which, I believe, is why it works fine.Checklist:
docs (N/A)