Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate code to TypeScript #81

Closed
mdjastrzebski opened this issue Aug 8, 2022 · 1 comment · Fixed by #101
Closed

refactor: migrate code to TypeScript #81

mdjastrzebski opened this issue Aug 8, 2022 · 1 comment · Fixed by #101
Labels
help wanted Extra attention is needed released

Comments

@mdjastrzebski
Copy link
Collaborator

Describe the feature you'd like:

Current code is written in JavaScript without any from of strong typing. We provide a TypeScript types file.

Idea is to migrate the whole code base to use TS.

Suggested implementation:

Migrate all code files to typescript.

Describe alternatives you've considered:

  • Stay as is, but we loss benefits of static type checking in our code.

Teachability, Documentation, Adoption, Migration Strategy:

  • Apply existing types to publicly exported functions
  • Add missing types
  • Remove type declaration file
@mdjastrzebski mdjastrzebski added the help wanted Extra attention is needed label Aug 8, 2022
@Ne3l Ne3l mentioned this issue Aug 15, 2022
Merged
8 tasks
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

breaking: Migrate codebase to typescript Ne3l/jest-native
1 participant
@mdjastrzebski