fix: .toBeVisible error with Pressable function style #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 208 224 +16
Branches 66 70 +4
=========================================
+ Hits 208 224 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@kaibarnes I've modified the implementation to match RNTL approach, i.e. performing tree walking only using host elements. This should fix the problem. |
mdjastrzebski
approved these changes
Dec 6, 2022
|
@mdjastrzebski Thanks. I confirmed locally that it seems to be working as expected now |
|
🎉 This PR is included in version 5.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #133
To fix an error when
.toBeVisibleis used on a Pressable using a function for thestylepropWhy:
Using a function is a documented use case (doc) and so it should be supported.
How:
By adding a check if the style prop is a function and calling it with
{ pressed: false }as a default value.Checklist: