Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing StyleProp type in TS definition file #123

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mironiasty
Copy link
Contributor

What:

extend-expect.d.ts is using StyleProp type, but this type is not imported. It causes TS error when library is using with other TypeScript projects.

Why:
To have error-free TS parser.

How:
By updating TS definition file.

Checklist:

  • Documentation added to the
    docs
  • Typescript definitions updated
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #123 (3995c81) into main (b36fc6c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          175       175           
  Branches        57        57           
=========================================
  Hits           175       175           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @mironiasty

@mdjastrzebski mdjastrzebski merged commit 901bb80 into testing-library:main Oct 21, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants