-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toHaveStyle nested arrays #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 151 140 -11
Branches 51 44 -7
=========================================
- Hits 151 140 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Seems like we could now completely remove mergeAll
as it's not used anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I've found an issue with the existing behaviour in isSubset
function, please take a look if my reasoning is sound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've updated the README.md examples to match current behavior.
🎉 This PR is included in version 4.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hey. @felippepuhle
ideally this should also be present along with
to check if only a certain property in transform is present or not |
@lokeshdangi I brought up the same topic while changing to the suggested implementation, answer is here: #110 (comment) |
What:
Closes #109
Why:
ramda
was removed on v4.0.11 which introduced a different behavior compared to what we had in the past, removing the ability of handling nested arrays as the style prop.How:
Simply replacing
mergeAllStyles
byStyleSheet.flatten
(fromreact-native
itself)Checklist:
docs (N/A)