-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update usage in README to make it more copy-pasty #326
Conversation
I spent some time going through the docs and the issues to enable it all. Could save people some time.
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 534 534
Branches 197 197
=========================================
Hits 534 534 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but I'm a bit on the fence. We already linked to the jest documentation about the file where jest-dom is to be imported.
Anyway, this is not to object. But I would indeed like to better address the TS vs. JS differences (see comment below). Or hear your thoughts about my thinking.
Co-authored-by: Ernesto García <[email protected]>
I was able to set it up with the current readme, but I needed to read into the Jest docs and find how to fix TS in the issues here, and I've used Jest a bit. So I figure some people may benefit from more hand-holding. |
@all-contributors please add @obedparla for docs |
I've put up a pull request to add @obedparla! 🎉 |
🎉 This PR is included in version 5.11.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Docs small update.
Why:
I spent some time going through the docs and the issues to enable it all. Could save people some time.