Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-node-access): enable in DOM config #661

Merged
merged 1 commit into from
Oct 2, 2022
Merged

feat(no-node-access): enable in DOM config #661

merged 1 commit into from
Oct 2, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Oct 2, 2022

BREAKING CHANGE: enable no-node-access by default in dom shared config

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Enable the no-node-access rule by default in the DOM shared configuration

Context

Resolves #620

BREAKING CHANGE: enable no-node-access by default in dom config
@Belco90 Belco90 merged commit b9a3198 into testing-library:alpha Oct 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🎉 This PR is included in version 6.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented Oct 2, 2022

@all-contributors please add @skovy for code, test, and docs

@allcontributors
Copy link
Contributor

@Belco90

@skovy already contributed before to code, test, doc

@Belco90
Copy link
Member

Belco90 commented Oct 2, 2022

@Belco90

@skovy already contributed before to code, test, doc

Oops, I didn't realized about that! Thanks for your amazing work on v6 @skovy.

@MichaelDeBoey MichaelDeBoey added the v6 Next major v6 label Oct 2, 2022
@skovy skovy deleted the pr/enable-no-await-sync-events branch October 2, 2022 22:31
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Oct 4, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat: enable no-node-access in dom shared config feat(no-node-access): enable in DOM config Oct 4, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Oct 4, 2022 that may be closed by this pull request
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
BREAKING CHANGE: `no-node-access` is now enabled by default in the DOM config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha v6 Next major v6
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable no-node-access in corresponding shareable config
3 participants