Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform await-fire-event into await-async-events #626

Closed
Belco90 opened this issue Aug 4, 2022 · 2 comments · Fixed by #652
Closed

Transform await-fire-event into await-async-events #626

Belco90 opened this issue Aug 4, 2022 · 2 comments · Fixed by #652
Labels
BREAKING CHANGE This change will require a major version bump v6 Next major v6

Comments

@Belco90
Copy link
Member

Belco90 commented Aug 4, 2022

Transform await-fire-event into await-async-events.

Since user-events v14 is async, we should transform this rule to consider both fire and user events.

It needs a new option to decide which modules are enabled or disabled:

  • fire-event: disabled by default since it's only used in Vue (enabled in Vue shareable config tho)
  • user-event: enabled by default since user-event 14 is async

Explain in the rule's doc that the user-event option must be disabled when working with user-event prior to v14
@Belco90 Belco90 added v6 Next major v6 BREAKING CHANGE This change will require a major version bump labels Aug 4, 2022
@MichaelDeBoey MichaelDeBoey changed the title Transform await-fire-event into await-async-events Transform await-fire-event into await-async-events Aug 4, 2022
@Belco90 Belco90 mentioned this issue Sep 7, 2022
Merged
3 tasks
@Belco90 Belco90 mentioned this issue Sep 16, 2022
Closed
@skovy skovy mentioned this issue Sep 29, 2022
Merged
3 tasks
@Belco90 Belco90 moved this from Todo to In Progress in eslint-plugin-testing-library v6 Sep 29, 2022
@Belco90 Belco90 closed this as completed Oct 2, 2022
Repository owner moved this from In Progress to Done in eslint-plugin-testing-library v6 Oct 2, 2022
@MichaelDeBoey MichaelDeBoey linked a pull request Oct 4, 2022 that will close this issue
feat: rename await-fire-event to await-async-event and support user-event #652
Merged
3 tasks
@skovy
Copy link
Collaborator

skovy commented Oct 5, 2022

@Belco90 @MichaelDeBoey assuming this was supposed to be plural? I can open a PR to fix it since it's currently await-async-event

@Belco90 Belco90 mentioned this issue Oct 5, 2022
Closed
@Belco90
Copy link
Member Author

Belco90 commented Oct 5, 2022

@Belco90 @MichaelDeBoey assuming this was supposed to be plural? I can open a PR to fix it since it's currently await-async-event

I didn't realize it wasn't plural! Please, open a small PR to rename it 🙏

@skovy skovy mentioned this issue Oct 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename await-fire-event to await-async-event and support user-event
2 participants
@Belco90 @skovy