Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): added new rule for prefer-to-have-style #76

Merged
merged 6 commits into from
Aug 31, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Aug 31, 2020

What: adds new rule for prefer to have style

Why: so people don't check styles.
fixes #74

How: with a new rule

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9        10    +1     
  Lines          139       183   +44     
  Branches        21        21           
=========================================
+ Hits           139       183   +44     
Impacted Files Coverage Δ
src/createBannedAttributeRule.js 100.00% <ø> (ø)
src/rules/prefer-empty.js 100.00% <ø> (ø)
src/rules/prefer-focus.js 100.00% <ø> (ø)
src/rules/prefer-to-have-attribute.js 100.00% <ø> (ø)
src/rules/prefer-to-have-text-content.js 100.00% <ø> (ø)
src/rules/prefer-to-have-style.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a12dc...deda65a. Read the comment docs.

@benmonro benmonro merged commit 8a55022 into master Aug 31, 2020
@benmonro benmonro deleted the feature/prefer-to-have-style branch August 31, 2020 03:09
@benmonro
Copy link
Member Author

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: prefer-to-have-style
1 participant