fix: add peer dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jwillebrands, I completely overlooked this. |
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I hope you don't mind the notification @jwillebrands , but I forgot to add you to our contributors. @all-contributors please add @jwillebrands for code |
|
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
|
@all-contributors please add @jwillebrands for code |
|
I've put up a pull request to add @jwillebrands! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent features (notably #40 and #48) have added additional peer dependencies that had not been added to the package.json. This is an issue when running under Bazel, where anything you do not explicitly list as a dependency is unavailable. Bazel works out the dependencies from package.json when you depend on an NPM package, thus resolving this for you when the (peer)dependencies are listed correctly.
I'm not sure if I can reproduce this in a plain Angular CLI project for you, but if needed I can provide a simple Bazel example showcasing the behaviour.