Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding installJestDom and installUserEvent as option to the ng-add schematic #478

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Hyperxq
Copy link
Contributor

@Hyperxq Hyperxq commented Aug 6, 2024

This pull request if for the issues:
#477
#472

With this change you need to update the documentation. The way to use both is:

ng add @testing-library/angular --install-jest-dom --install-user-event

By default both are in false for this reason, no matter if the users are still using as documentation.

@timdeschryver

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @Hyperxq , I've added a comment

@Hyperxq
Copy link
Contributor Author

Hyperxq commented Aug 6, 2024

@timdeschryver ready!

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver timdeschryver merged commit 641c65f into testing-library:main Aug 6, 2024
4 checks passed
@timdeschryver
Copy link
Member

@all-contributors please add @Hyperxq for code

Copy link
Contributor

@timdeschryver

I've put up a pull request to add @Hyperxq! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants