Feat: Added childComponentOverrides property to override nested child providers #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oviders and fixed linting errors from existing tests
JJosephttg
changed the title
|
@all-contributors please add @JJosephttg for code, tests |
|
I've put up a pull request to add @JJosephttg! 🎉 |
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow for specific child components to be overridden with providers as the introduction of standalone components and scoping services to specific components make it difficult to mock out services that might talk to external dependencies, especially when the component you are testing is higher up. Currently there is no way to mock component level providers for nested children which this tries to address.
Feel free to leave suggestions for improvements. I am hoping to at least get something out the door so that it is at least possible to override child providers.
I also added a test and an example in the description to show how this works