fix: don't fire router events on render #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to represent a more real Angular running environment
|
🎉 This PR is included in version 13.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
timdeschryver
added a commit
that referenced
this pull request
Dec 8, 2022
timdeschryver
added a commit
that referenced
this pull request
Dec 14, 2022
* feat: update to Angular 15
* feat: rename ɵcomponentImports to componentImports
BREAKING CHANGE:
The render property ɵcomponentImports is not experimental anymore, and is renamed to componentImports
BEFORE:
```ts
render(ParentComponent, {
ɵcomponentImports: [ChildComponent],
});
```
AFTER:
```ts
render(ParentComponent, {
componentImports: [ChildComponent],
});
```
* docs: update material inputs example (#324)
* fix: don't fire router events on render (#325)
Closes #318
* fix: don't invoke ngOnChanges when no properties are provided (#326)
Closes #323
BREAKING CHANGE:
This change is made to have the same behavior as the run time behavior.
BEFORE:
The `ngOnChanges` lifecycle is always invoked when a component is rendered.
AFTER:
The `ngOnChanges` lifecycle is only invoked if a component is rendered with `componentProperties`.
* feat: add more fine-grained control over inputs and outputs (#328)
BREAKING CHANGE:
`rerender` expects properties to be wrapped in an object containing `componentProperties` (or `componentInputs` and `componentOutputs` to have a more fine-grained control).
BEFORE:
```ts
await render(PersonComponent, {
componentProperties: {
name: 'Sarah'
}
});
await rerender({ name: 'Sarah 2' });
```
AFTER:
```ts
await render(PersonComponent, {
componentProperties: {
name: 'Sarah'
}
});
await rerender({
componentProperties: {
name: 'Sarah 2'
}
});
```
* feat: add ability to turn off auto detect changes (#329)
* chore: update peer dependencies (#330)
BREAKING CHANGE:
BEFORE:
The minimum version of Angular is v14.0.0
AFTER:
The minimum version of Angular is v14.1.0
* feat: childComponentOverrides is stable (#338)
* fix: invoke changeChanges once on input change (#339)
* feat: remove detectChanges in favor of detectChangesOnRender (#341)
BREAKING CHANGE:
The config property detectChanges is renamed to detectChangesOnRender.
BEFORE:
```ts
const component = await render(AppComponent, {
detectChanges: false
});
```
AFTER:
```ts
const component = await render(AppComponent, {
detectChangesOnRender: false
});
```
* test: extra tests for ngOnChanges (#342)
* test: add test example for harness (#343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to represent a more real Angular running environment
Closes #318