Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support static env config from file #687

Closed
Tranquility2 opened this issue Aug 17, 2024 · 2 comments · Fixed by #737
Closed

Feature: Support static env config from file #687

Tranquility2 opened this issue Aug 17, 2024 · 2 comments · Fixed by #737

Comments

@Tranquility2
Copy link
Contributor

What are you trying to do?

Add missing implementation of docker run --env-file <file> ...

Why should it be done this way?

Users should not be required to load each env var manually if they have an env file.
(this is the common case for quite a few services)

For example, if I would have an Redis service with some config:

# Redis Bike Commpany Demo Application: Example .env file.
REDIS_URL=redis://localhost:6379/?decode_responses=True
BIKE_INDEX_NAME="idx:bikes"
STORE_INDEX_NAME="idx:stores"
REDIS_KEY_BASE="redisbikeco"
BIKE_KEY_BASE="redisbikeco:bike"
STORE_KEY_BASE="redisbikeco:store"
FLASK_ENV=development

We would now be able to load it without evoking with_env 7 times + keeping a single source of truth for the env config.

Other references:

Docker official Docs

@biniyam69
Copy link

@Tranquility2 wanna work on this together?

@Tranquility2
Copy link
Contributor Author

@biniyam69 checkout #684 if you have any comment/ideas/remarks I'll be happy to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants